Skip to content

Generalize the VDP API: struct vrt_init_ctx #4111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

nigoroll
Copy link
Member

This commit is to prepare use of the VDP API also for the backend side to filter bereq.body through bereq.filters by adding a struct vrt_init_ctx argument to the VDP init function.

For background, see #4035

nigoroll added 2 commits May 29, 2024 13:56
This commit is to prepare use of the VDP API also for the backend
side to filter bereq.body through bereq.filters by adding a struct
vrt_init_ctx argument to the VDP init function.

For background, see varnishcache#4035
@dridi
Copy link
Member

dridi commented Jul 8, 2024

As mentioned during bugwash, I prefer the #4112 approach.

@nigoroll
Copy link
Member Author

As both @bsdphk and @dridi prefer #4112, we will continue there and give up this suggestion.

(side note for the eternal internet void: They both surprised me to prefer a struct where most members are only valid/relevant for an init function)

@nigoroll nigoroll closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants