Varnisncsa: Change matching rules to reflect reality #4213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dridi
reviewed
Oct 14, 2024
walid-git
force-pushed
the
varnisncsa_match_rules
branch
from
b6c21ef
to
cbc5843
Compare
dridi
requested changes
Oct 31, 2024
walid-git
force-pushed
the
varnisncsa_match_rules
branch
from
cbc5843
to
4d66ff0
Compare
|
Discussed this offline with @dridi. Force pushed a (hopefully) much cleaner version now. All review items should be addressed/obsolete. |
dridi
requested changes
Nov 4, 2024
walid-git
force-pushed
the
varnisncsa_match_rules
branch
from
4d66ff0
to
5f6107c
Compare
This is needed in order to differentiate between what was sent/received to/from the client/server and the changes made to [be]req/resp in VCL. It should be noted that this is the best approximation we can get as of today, as there is no reliable vsl tag to tell exactly when we have finished receiving a req/beresp, therefore we have to use vcl_recv and vcl_backend_response for now.
With this change, [Be]resp/[Be]req formats should reflect better what was received/sent from/to the backend/client without taking irrelevant VCL changes into account. There is however still an exception for the changes performed by the core code before vcl_recv for req and before vcl_backend_response for beresp that cannot be distinguished from the original headers. Refs: varnishcache#3528
walid-git
force-pushed
the
varnisncsa_match_rules
branch
from
5f6107c
to
7342d70
Compare
|
Sorry for the mix-up, I have updated the PR now, let me know if it's still missing something. |
walid-git
force-pushed
the
varnisncsa_match_rules
branch
from
7342d70
to
de4b66c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the changes discussed in #3528
The relevant parts of [BE]requests/responses are now shown as they were received/sent from/to the peer, without taking irrelevant VCL changes into account. This PR also introduces the handling of Unset headers in varnishncsa.
Note: this breaks the default behavior of varnishncsa.
Fixes #3528.