Fix example + distcheck #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
vasi
commented
Nov 9, 2023
•
vasi
commented
- Add extra dependencies to README example, it should work now in a docker ubuntu:jammy container
- While testing that this was fixed, noticed that out-of-tree builds and tests from release tarballs are both broken!
- Added some missing files to the dist tarball
- Made ll-smoke-singlethreaded aware of where ll-smoke lives, so it can be run out of tree
- Added a new test to enforce that dist builds are working
vasi
force-pushed
the
update-example2
branch
2 times, most recently
from
c6c61e8 to
bfc5ab0
Compare
* Include some missing test files in dist (+ some docs) * Make ll-smoke-singlethreaded not get confused by out-of-tree builds * Run distcheck in CI
|
@DrDaveD Does this look reasonable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.