Skip to content

Comments

complete project#24

Open
5arav031k wants to merge 17 commits intovasylmalik:masterfrom
5arav031k:master
Open

complete project#24
5arav031k wants to merge 17 commits intovasylmalik:masterfrom
5arav031k:master

Conversation

@5arav031k
Copy link

No description provided.

currentSession.setAttribute("data", data);

LOGGER.info("Game started, field initialized");
getServletContext().getRequestDispatcher("/index.jsp").forward(req, resp);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move all jsp's into constants

import java.io.IOException;
import java.util.List;

@WebServlet(name = "LogicServlet", value = "/logic")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not informative url

private static final Logger LOGGER = LogManager.getLogger(LogicServlet.class);

@Override
protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buisness logic inside servlet, move it into separate class(serive)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants