Skip to content

Commit

Permalink
Drop obsolete arb doctest tags
Browse files Browse the repository at this point in the history
  • Loading branch information
antonio-rojas committed Feb 26, 2024
1 parent 633b368 commit 6e904cf
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 20 deletions.
2 changes: 1 addition & 1 deletion src/.relint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,4 @@
magic doctest comments should appear on the "sage:" line, not "....:" lines
# see optional_regex in src/sage/doctest/parsing.py
# "indirect doctest" is from src/bin/sage-coverage
pattern: '^[ ]*[.][.][.][.]:.*#.*(arb216|arb218|py2|py3|long time|not implemented|not tested|known bug|optional|indirect doctest)'
pattern: '^[ ]*[.][.][.][.]:.*#.*(py2|py3|long time|not implemented|not tested|known bug|optional|indirect doctest)'
4 changes: 1 addition & 3 deletions src/sage/doctest/parsing.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def fake_RIFtol(*args):
ansi_escape_sequence = re.compile(r"(\x1b[@-Z\\-~]|\x1b\[.*?[@-~]|\x9b.*?[@-~])")

special_optional_regex = (
"arb216|arb218|py2|long time|not implemented|not tested|optional|needs|known bug"
"py2|long time|not implemented|not tested|optional|needs|known bug"
)
tag_with_explanation_regex = r"((?:\w|[.])*)\s*(?:\((?P<cmd_explanation>.*?)\))?"
optional_regex = re.compile(
Expand Down Expand Up @@ -136,8 +136,6 @@ def parse_optional_tags(
- ``'not tested'``
- ``'known bug'`` (possible values are ``None``, ``linux`` and ``macos``)
- ``'py2'``
- ``'arb216'``
- ``'arb218'``
- ``'optional - FEATURE...'`` or ``'needs FEATURE...'`` --
the dictionary will just have the key ``'FEATURE'``
Expand Down
8 changes: 2 additions & 6 deletions src/sage/rings/complex_arb.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -4792,18 +4792,14 @@ cdef class ComplexBall(RingElement):
sage: n = CBF(1,1)
sage: m = CBF(-2/3, 3/5)
sage: n.elliptic_pi_inc(CBF.pi()/2, m) # arb216
[0.8934793755173 +/- ...e-14] + [0.95707868710750 +/- ...e-15]*I
sage: n.elliptic_pi_inc(CBF.pi()/2, m) # arb218 - this is a regression, see :trac:28623
sage: n.elliptic_pi_inc(CBF.pi()/2, m) # this is a regression, see :trac:28623
nan + nan*I
sage: n.elliptic_pi(m)
[0.8934793755173...] + [0.957078687107...]*I
sage: n = CBF(2, 3/7)
sage: m = CBF(-1/3, 2/9)
sage: n.elliptic_pi_inc(CBF.pi()/2, m) # arb216
[0.2969588746419 +/- ...e-14] + [1.3188795332738 +/- ...e-14]*I
sage: n.elliptic_pi_inc(CBF.pi()/2, m) # arb218 - this is a regression, see :trac:28623
sage: n.elliptic_pi_inc(CBF.pi()/2, m) # this is a regression, see :trac:28623
nan + nan*I
sage: n.elliptic_pi(m)
[0.296958874641...] + [1.318879533273...]*I
Expand Down
12 changes: 2 additions & 10 deletions src/sage/rings/real_arb.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -294,11 +294,7 @@ cdef int arb_to_mpfi(mpfi_t target, arb_t source, const long precision) except -
EXAMPLES::
sage: RIF(RBF(2)**(2**100)) # arb216 # indirect doctest
Traceback (most recent call last):
...
ArithmeticError: Error converting arb to mpfi. Overflow?
sage: RIF(RBF(2)**(2**100)) # arb218 # indirect doctest
sage: RIF(RBF(2)**(2**100))
[5.8756537891115869e1388255822130839282 .. +infinity] # 64-bit
[2.098... .. +infinity] # 32-bit
Expand Down Expand Up @@ -1729,11 +1725,7 @@ cdef class RealBall(RingElement):
::
sage: b = RBF(2)^(2^1000)
sage: b.mid() # arb216
Traceback (most recent call last):
...
RuntimeError: unable to convert to MPFR (exponent out of range?)
sage: b.mid() # arb218
sage: b.mid()
+infinity
.. SEEALSO:: :meth:`rad`, :meth:`squash`
Expand Down

0 comments on commit 6e904cf

Please sign in to comment.