Skip to content

Commit

Permalink
sagemathgh-36991: Fixed doc_test in database.findstat by adding new…
Browse files Browse the repository at this point in the history
… collection

This pull request addresses the doctest failures reported when testing
the `findstat` module. The failures are related to the addition of a new
collection, causing discrepancies in the expected and actual results.

The doctest failures were observed with the following optional packages:
```
--optional=4ti2,antic,build,cbc,ccache,cryptominisat,debian,dot2tex,e_an
tic,external,fricas,glucose,kissat,latte_int,lidia,normaliz,pip,sage,sag
e_numerical_backends_coin,sage_spkg
```
I have updated the doctests to include the new collection in the
expected results.
Fixes sagemath#36481
### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.

URL: sagemath#36991
Reported by: Aman Moon
Reviewer(s): Martin Rubey
  • Loading branch information
Release Manager committed Jan 5, 2024
2 parents f3f2d7b + fa606f3 commit cfdfd1b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
6 changes: 3 additions & 3 deletions build/pkgs/configure/checksums.ini
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
tarball=configure-VERSION.tar.gz
sha1=05115739db242cb5a48ae17f97d06b179fc70334
md5=adc8208885e6be527b089b682079c464
cksum=3321256447
sha1=d91e351812c6530bdc3a6ac3538b20fdff5b0e73
md5=19c4f02d2219f3ec05a49464f3aaccd9
cksum=3971021488
2 changes: 1 addition & 1 deletion build/pkgs/configure/package-version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
e95536ccbad199de456e804968a775f2744e4bff
82b4df9a0cae79e4d3f3dddf155b22d781910d28
7 changes: 5 additions & 2 deletions src/sage/databases/findstat.py
Original file line number Diff line number Diff line change
Expand Up @@ -4318,6 +4318,7 @@ def in_range(self, element):
Cc0027: Signed permutations 4282 True
Cc0028: Skew partitions 1250 True
Cc0029: Lattices 1378 True
Cc0030: Ordered set partitions 5316 True
"""
return self._data["Code"].element_level(element) in self._data["LevelsWithSizes"]

Expand Down Expand Up @@ -4711,7 +4712,8 @@ class FindStatCollections(UniqueRepresentation, Parent):
Cc0026: Decorated permutations,
Cc0027: Signed permutations,
Cc0028: Skew partitions,
Cc0029: Lattices]
Cc0029: Lattices,
Cc0030: Ordered set partitions]
"""
def __init__(self):
"""
Expand Down Expand Up @@ -4787,7 +4789,8 @@ def _element_constructor_(self, entry):
Cc0026: Decorated permutations,
Cc0027: Signed permutations,
Cc0028: Skew partitions,
Cc0029: Lattices]
Cc0029: Lattices,
Cc0030: Ordered set partitions]
sage: FindStatCollection(Permutation([1,2,3])) # optional -- internet
Cc0001: Permutations
Expand Down

0 comments on commit cfdfd1b

Please sign in to comment.