Skip to content

Commit

Permalink
sagemathgh-38215: Fix typo "sage.ring" in docstrings
Browse files Browse the repository at this point in the history
    
The correct module path is "sage.rings" instead of "sage.ring".
In sage/modular/pollack_stevens/padic_lseries.py and in
sage/structure/factory.pyx the typo prevents doctests from being run
because the "needs" requirement canot be fulfilled.
In sage/rings/polynomial/padics/polynomial_padic.py the typo is merely
cosmetic.

See brief [discussion in Sage Support
Group](https://groups.google.com/g/sage-support/c/Msx0QJF7rpA)

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
/

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38215
Reported by: Jens-Erik Riedel
Reviewer(s): David Coudert, Julian Rüth
  • Loading branch information
Release Manager committed Jun 16, 2024
2 parents 00baa0b + d08315f commit d4ed32d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/sage/modular/pollack_stevens/padic_lseries.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# sage.doctest: needs sage.ring.padics
# sage.doctest: needs sage.rings.padics
r"""
`p`-adic `L`-series attached to overconvergent eigensymbols
Expand Down Expand Up @@ -174,7 +174,7 @@ def __eq__(self, other):
sage: E = EllipticCurve('11a')
sage: L = E.padic_lseries(11,implementation="pollackstevens",precision=6) # long time
sage: L == loads(dumps(L)) # indirect doctest long time
sage: L == loads(dumps(L)) # indirect doctest, long time
True
"""
if not isinstance(other, pAdicLseries):
Expand Down
2 changes: 1 addition & 1 deletion src/sage/rings/polynomial/padics/polynomial_padic.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ def root_field(self, names, check_irreducible=True, **kwds):
* ``check_irreducible`` -- check whether the polynomial is irreducible
* ``kwds`` -- see :meth:`sage.ring.padics.padic_generic.pAdicGeneric.extension`
* ``kwds`` -- see :meth:`sage.rings.padics.padic_generic.pAdicGeneric.extension`
EXAMPLES::
Expand Down
2 changes: 1 addition & 1 deletion src/sage/structure/factory.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ cdef class UniqueFactory(SageObject):
The ``GF`` factory used to have a custom :meth:`other_keys`
method, but this was removed in :issue:`16934`::
sage: # needs sage.libs.linbox sage.ring.finite_rings
sage: # needs sage.libs.linbox sage.rings.finite_rings
sage: key, _ = GF.create_key_and_extra_args(27, 'k'); key
(27, ('k',), x^3 + 2*x + 1, 'givaro', 3, 3, True, None, 'poly', True, True, True)
sage: K = GF.create_object(0, key); K
Expand Down

0 comments on commit d4ed32d

Please sign in to comment.