Skip to content

Commit

Permalink
sagemathgh-37970: Fix sign error in the Kerr metric of the manifold c…
Browse files Browse the repository at this point in the history
…atalog

<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

In the Kerr spacetime constructed from the manifold catalog (i.e.
returned by  `manifolds.Kerr`), there was an error in the sign of the
g_{03} component of the metric tensor with respect to Boyer-Lindquist
coordinates. This is fixed here.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

URL: sagemath#37970
Reported by: Eric Gourgoulhon
Reviewer(s): Travis Scrimshaw
  • Loading branch information
Release Manager committed May 12, 2024
2 parents 4e0bbaf + 5731edb commit f5e7884
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 7 deletions.
6 changes: 3 additions & 3 deletions build/pkgs/configure/checksums.ini
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
tarball=configure-VERSION.tar.gz
sha1=599182ff950764df31446f7bf8350499717dc76e
md5=06e0643f4948ad4b4c87d2530d026a1f
cksum=4286155814
sha1=fa7d8e54b6563001256eac25159c14cdb3619004
md5=15cf5e8fb1b18afc819922d8218721a8
cksum=2753177283
2 changes: 1 addition & 1 deletion build/pkgs/configure/package-version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
e77b3df44ade2f51f750de90ad255f772a933776
8eaeb3e77110a5e6b866f7cded0a3e4953fd6c3f
14 changes: 11 additions & 3 deletions src/sage/manifolds/catalog.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,14 +127,19 @@ def Kerr(m=1, a=0, coordinates="BL", names=None):
4-dimensional Lorentzian manifold M
sage: K.atlas()
[Chart (M, (t, r, th, ph))]
The Kerr metric in Boyer-Lindquist coordinates (cf. :wikipedia:`Kerr_metric`)::
sage: K.metric().display()
g = (2*m*r/(a^2*cos(th)^2 + r^2) - 1) dt⊗dt
+ 2*a*m*r*sin(th)^2/(a^2*cos(th)^2 + r^2) dt⊗dph
- 2*a*m*r*sin(th)^2/(a^2*cos(th)^2 + r^2) dt⊗dph
+ (a^2*cos(th)^2 + r^2)/(a^2 - 2*m*r + r^2) dr⊗dr
+ (a^2*cos(th)^2 + r^2) dth⊗dth
+ 2*a*m*r*sin(th)^2/(a^2*cos(th)^2 + r^2) dph⊗dt
- 2*a*m*r*sin(th)^2/(a^2*cos(th)^2 + r^2) dph⊗dt
+ (2*a^2*m*r*sin(th)^2/(a^2*cos(th)^2 + r^2) + a^2 + r^2)*sin(th)^2 dph⊗dph
The Schwarzschild spacetime with the mass parameter set to 1::
sage: K.<t, r, th, ph> = manifolds.Kerr()
sage: K
4-dimensional Lorentzian manifold M
Expand All @@ -144,6 +149,9 @@ def Kerr(m=1, a=0, coordinates="BL", names=None):
sage: K.default_chart().coord_range()
t: (-oo, +oo); r: (0, +oo); th: (0, pi); ph: [-pi, pi] (periodic)
The Kerr spacetime in Kerr coordinates::
sage: m, a = var('m, a')
sage: K.<t, r, th, ph> = manifolds.Kerr(m, a, coordinates="Kerr")
sage: K
Expand Down Expand Up @@ -205,7 +213,7 @@ def Kerr(m=1, a=0, coordinates="BL", names=None):
g[0, 0], g[1, 1], g[2, 2], g[3, 3] = -(1-2*m*r/rho**2), \
rho**2/(r**2-2*m*r+a**2), rho**2, \
(r**2+a**2+2*m*r*a**2/rho**2*sin(th)**2)*sin(th)**2
g[0, 3] = 2*m*r*a*sin(th)**2/rho**2
g[0, 3] = -2*m*r*a*sin(th)**2/rho**2
return M

raise NotImplementedError("coordinates system not implemented, see help"
Expand Down

0 comments on commit f5e7884

Please sign in to comment.