Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric updates #707

Merged
merged 46 commits into from
Jul 22, 2024
Merged

Metric updates #707

merged 46 commits into from
Jul 22, 2024

Conversation

kev306
Copy link
Collaborator

@kev306 kev306 commented Jul 4, 2024 •
edited
Loading

  • Initialise metrics with labels to 0 on process start (prior they were N/A)
  • Added validations for labelNames + options. Options to be passed in at config stage

vck3000
vck3000 reviewed Jul 4, 2024
View reviewed changes
src/metrics/gameMetrics.ts Outdated Show resolved Hide resolved
@kev306 kev306 requested a review from vck3000 July 7, 2024 08:18
@kev306 kev306 requested a review from vck3000 July 9, 2024 10:24
vck3000
vck3000 reviewed Jul 9, 2024
View reviewed changes
src/sockets/sockets.ts Outdated Show resolved Hide resolved
@kev306 kev306 merged commit ca7eee3 into master Jul 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vck3000 vck3000 vck3000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kev306 @vck3000