Cleanup after milestone 5/4 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove trivial tests that don't add value (config, basic DB connection tests). - Convert multi-case tests to table-driven format across all packages (api, db, imap). - Replace manual mock implementations with mockery-generated mocks for IMAPService, IMAPPool, IMAPClient, and ThreadCountUpdater. - Use testify assertions throughout for better error messages - Create shared test helpers in api_test_helpers.go to reduce duplication. - Add testify and mockery dependencies with documentation. - Extract ThreadCountUpdater interface for better testability. - Fix variable shadowing issue in folder_test.go - Update AGENTS.md, testing.md, and technical-decisions.md with new testing patterns.
The most important changes: - Rewrote check.sh from bash to Go for better maintainability, in a modular structure. - Added auto-fixing for gofmt, prettier, and eslint (disabled with --ci flag). Improvements: - Added execution time display for each check and total runtime. - Also enabled tests for the /scripts directory - Enabled ESLint and Prettier for E2E tests. E2E tests moved to /frontend/e2e. - Reformatted all E2E test files with Prettier. Fixes: - Fixed E2E double-run issue by capturing output on first run Other changes: - Updated CI workflow to use new check binary with --ci flag - Updated documentation to match other script READMEs - Removed unused code (printSuccess, printWarning, CheckResult)
To help keep the project up to date
- Add Procfile.dev and backend/.air.toml for single-command dev setup - Update CONTRIBUTING.md with Overmind quick start guide - Document new dev tools in docs/tech-stack.md - Make .env finding logic more resilient
vdavid
force-pushed
the
cleanup-after-5-4
branch
5 times, most recently
from
6f2e2c9 to
618ee74
Compare
vdavid
force-pushed
the
cleanup-after-5-4
branch
from
618ee74 to
4e217cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages