Rm props-passing of playback via <audio/>

Playback state is init @ point of events registration, via a new bridge now.
ve1ld · Aug 9, 2024 · 26a1ae9 · 26a1ae9
1 parent d627c53
commit 26a1ae9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/assets/js/hooks/audio_player.js b/assets/js/hooks/audio_player.js
@@ -132,13 +132,11 @@ AudioPlayer = {
   },
   handlePlayableState(e) {
     console.log("TRACE HandlePlayableState", e);
-    const playback = JSON.parse(this?.player?.dataset?.playback);
     // this.initMediaSession(playback);
   },
   // DEPRECATED: the state setting already happens at the point of loading, we don't need to listen to any metadata load event now now.
   handleMetadataLoad(e) {
     console.log("TRACE HandleMetadataLoad", e);
-    const playback = JSON.parse(this?.player?.dataset?.playback);
     // this.initMediaSession(playback);
   },
   handlePlayPause() {

diff --git a/lib/vyasa_web/components/audio_player.ex b/lib/vyasa_web/components/audio_player.ex
@@ -18,7 +18,7 @@ defmodule VyasaWeb.AudioPlayer do
     # TODO: remove the reliance on the playback prop passed here, it forces a remounting of the node, which is undesirable
     ~H"""
     <div id="audio-player" phx-hook="AudioPlayer">
-      <audio data-playback={Jason.encode!(@playback)}></audio>
+      <audio></audio>
     </div>
     """
   end