Merged
Conversation
waldls
requested review from
HiJuwon,
gaeulzzang,
jinj00oo and
sunhwaaRj
as code owners
HiJuwon
approved these changes
Aug 26, 2025
Collaborator
HiJuwon
left a comment
HiJuwon
left a comment
There was a problem hiding this comment.
모두 확인했습니다. 참고해서 저도 주석 정리 해보겠습니다 bb
|
|
||
| // 워크스페이스 URL 생성 | ||
| export interface CreateWorkspaceUrlRequest { | ||
| export type CreateWorkspaceUrlRequest = { |
Collaborator
There was a problem hiding this comment.
코드 통일성 향상 차원에서 type으로 맞추어주신 것도 좋습니다~~!
sunhwaaRj
approved these changes
Aug 27, 2025
Collaborator
sunhwaaRj
left a comment
sunhwaaRj
left a comment
There was a problem hiding this comment.
링크 연결 방법과 타입정의 통일 좋아욥👍👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
체크리스트
📌 관련 이슈번호
✅ Key Changes
window.open->window.location.href로 변경하였습니다. (다른 분들의 코드와 통일성을 위함입니다.)interface->type으로 변경하였습니다. (다른 분들의 코드와 통일성을 위함입니다.)cursor-pointer속성 추가하였습니다.📸 스크린샷 or 실행영상
페이지 동작에 변화가 있는 부분은 없습니다.
💬 To Reviewers
제거한 주석 부분 중 살리는 게 더 나은 게 있다면 알려주세요~!!