fix(ci): always run IT suite when in a merge group

[pront]

Summary

Always run the integration test suite before merging the PR.
Arguably, this can be optimized by keeping track of dependencies per test but this way merging is safer and can detect bugs caused by dependency updates.

Change Type

• Bug fix
• New feature
• Non-functional (chore, refactoring, docs)
• Performance

Is this a breaking change?

• Yes
• No

How did you test this PR?

Does this PR include user facing changes?

• Yes. Please add a changelog fragment based on our guidelines.
• No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

• Please read our Vector contributor resources.
  • make check-all is a good command to run locally. This check is
    defined here. Some of these
    checks might not be relevant to your PR. For Rust changes, at the very least you should run:
    • cargo fmt --all
    • cargo clippy --workspace --all-targets -- -D warnings
    • cargo nextest run --workspace (alternatively, you can run cargo test --all)
• If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
  run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

Ref: #22242 (comment)

[jszwedko]

Actually, the base_ref and head_ref won't be right when ran by the MQ. You may need to check changes.yml to make sure it isn't expecting to be run only by pull requests, too.

[pront]

Actually, the base_ref and head_ref won't be right when ran by the MQ. You may need to check changes.yml to make sure it isn't expecting to be run only by pull requests, too.

Great catch. I implemented your suggestion in 939be7c (per https://docs.github.com/en/webhooks/webhook-events-and-payloads#merge_group)

[datadog-vectordotdev]

Datadog Report

Branch report: pront/fix-changes-if-cond-ci
Commit report: c819a6e
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.46s Total Time