Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): refactor and parallelize integration-tests (CI review) #22380

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

pront
Copy link
Member

@pront pront commented Feb 7, 2025

Summary

Greatly simplifies the ci-integration-review.yml workflow. Also, integration tests can now run in parallel.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
    • make check-all is a good command to run locally. This check is
      defined here. Some of these
      checks might not be relevant to your PR. For Rust changes, at the very least you should run:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Feb 7, 2025
pront

This comment was marked as outdated.

@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Feb 7, 2025

Datadog Report

Branch report: pront/ci-IT-parallel
Commit report: 15ffbf9
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.43s Total Time

@pront pront changed the title feat(ci): refactor and parallelize integration-tests (CI review) [WIP] feat(ci): refactor and parallelize integration-tests (CI review) Feb 7, 2025
@pront pront marked this pull request as ready for review February 7, 2025 00:18
@pront pront requested a review from a team as a code owner February 7, 2025 00:18
Copy link
Member Author

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-integration-all

@pront pront changed the title [WIP] feat(ci): refactor and parallelize integration-tests (CI review) feat(ci): refactor and parallelize integration-tests (CI review) Feb 7, 2025
@pront pront requested a review from jszwedko February 7, 2025 00:29
@pront
Copy link
Member Author

pront commented Feb 7, 2025

Tests failed due to #22379

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I've wanted to do this for a long while.

@pront pront added this pull request to the merge queue Feb 7, 2025
@pront pront removed this pull request from the merge queue due to a manual request Feb 7, 2025
@pront pront enabled auto-merge February 7, 2025 18:32
@pront pront added this pull request to the merge queue Feb 7, 2025
Merged via the queue into master with commit 22ee402 Feb 7, 2025
43 checks passed
@pront pront deleted the pront/ci-IT-parallel branch February 7, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants