enhancement(aws_s3 sink): Emit log when putting an object to s3-compatible storage#23390
Merged
pront merged 9 commits intovectordotdev:masterfrom Jul 29, 2025
Merged
Conversation
pront
reviewed
Jul 18, 2025
This reverts commit fb8a8ed.
maycmlee
reviewed
Jul 21, 2025
Contributor
maycmlee
left a comment
There was a problem hiding this comment.
Couple of small suggestions
Co-authored-by: May Lee <may.lee@datadoghq.com>
Contributor
Author
|
Can |
pront
reviewed
Jul 29, 2025
pront
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This creates a log event went writing to an s3-compatible storage. This is intended to allow for the log to be captured with the
internal_logssource and use the bucket and key to send off to another sink.How did you test this PR?
Setting
VECTOR_LOGtovector::sinks::s3_common::service::put_object=trace,info.Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Related: #22994
Related: #23234 (4 of 4)
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo nextest run --workspace(alternatively, you can runcargo test --all)git merge origin masterandgit push.Cargo.lock), pleaserun
cargo vdev build licensesto regenerate the license inventory and commit the changes (if any). More details here.