Skip to content

enhancement(aws_s3 sink): Emit log when putting an object to s3-compatible storage#23390

Merged
pront merged 9 commits intovectordotdev:masterfrom
5Dev24:enhancement/log-on-s3-write
Jul 29, 2025
Merged

enhancement(aws_s3 sink): Emit log when putting an object to s3-compatible storage#23390
pront merged 9 commits intovectordotdev:masterfrom
5Dev24:enhancement/log-on-s3-write

Conversation

@5Dev24
Copy link
Contributor

@5Dev24 5Dev24 commented Jul 16, 2025

Summary

This creates a log event went writing to an s3-compatible storage. This is intended to allow for the log to be captured with the internal_logs source and use the bucket and key to send off to another sink.

How did you test this PR?

Setting VECTOR_LOG to vector::sinks::s3_common::service::put_object=trace,info.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Related: #22994
Related: #23234 (4 of 4)

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

@5Dev24 5Dev24 requested a review from a team as a code owner July 16, 2025 21:23
@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Jul 16, 2025
@thomasqueirozb thomasqueirozb added the meta: awaiting author Pull requests that are awaiting their author. label Jul 18, 2025
@5Dev24 5Dev24 requested a review from a team as a code owner July 21, 2025 18:33
@github-actions github-actions bot added domain: external docs Anything related to Vector's external, public documentation and removed meta: awaiting author Pull requests that are awaiting their author. labels Jul 21, 2025
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small suggestions

@5Dev24
Copy link
Contributor Author

5Dev24 commented Jul 28, 2025

Can no-changelog be added to this PR?

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jul 29, 2025
@pront pront enabled auto-merge July 29, 2025 14:14
@pront pront added this pull request to the merge queue Jul 29, 2025
Merged via the queue into vectordotdev:master with commit e326e65 Jul 29, 2025
96 checks passed
@5Dev24 5Dev24 deleted the enhancement/log-on-s3-write branch July 29, 2025 15:04
@5Dev24 5Dev24 restored the enhancement/log-on-s3-write branch August 5, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants