itest: rewrite the participant modes itest #254
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VDanielEdwards
force-pushed
the
dev/tests/fix-hangup-itest-participant-modes
branch
2 times, most recently
from
5dc68fa to
c3bdf05
Compare
VDanielEdwards
force-pushed
the
dev/tests/fix-hangup-itest-participant-modes
branch
from
cbf05eb to
e76978e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Rewrites the
ITest_Internals_ParticipantModessuch that it doesn't rely on internal functions anymore, doesn't wait indefinitely anymore, and 'gracefully' crashes if a thread does hang.TODO:
RunnerBaseas it currently provides helper methods and fields for all runner typesAutonomousFreerunningRequiredWorksWithCoordinatedSynchronizedtest sometimes fails to shutdown all threads as the halt signal arrives before the last participant (the system controller) is able to receive the 'halt' signal. It might work better if the runners utilize a work-queue (like the orchestrator) wince that would allow to 'split' setup and the main-loop execution, while directing it from the orchestrator.Developer checklist (address before review)