Replace task macro with trait #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the macro provided good ergonomics, it hardcoded configuration parameters and hid a lot of how a task is actually created. It was also possible to create tasks from anywhere in the dependency tree without control of the PXROS application developer. With the task trait, all configurations are user accessible and task creation is done in one single point.
A builder allows more ergonomic overriding of single parts of the configuration without providing many combinations of override methods. The current implementation prevents accidentally overriding the same configuration twice, thus making it more user-friendly and misuse-resistant. --------- Co-authored-by: vE5li <ve5li@tuta.io>
vE5li
approved these changes
Apr 4, 2024
|
Very nice! 👍 |
|
Please wait my review also! |
daniel-veecle
approved these changes
Apr 16, 2024
This should be implemented by trait implementations
|
The comments should be addressed now. I would like to add some tests, at least for the task creation config and builder. The tests are kinda blocked by |
|
Very good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task trait allows users to modify all aspects of task configuration and creation. By using a trait, we also enable easy task re-use and sharing, thus allowing users to share tasks in crates.
This also removes the possibility of defining a PXROS task anywhere in the dependency tree in favor of a central point to define all tasks. This improves clarity and transparency for users.