Make using fences on DX12 optional via cargo feature #225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed pretty significant FPS drops in my games when injecting even the most basic hello world examples. I was able to track it down to this fence usage. As an example, in the game I am working on I get ~460FPS sitting in the town, but as soon as I inject the hello world example from the README it drops down to around ~240FPS. With this change I stick within ~10FPS of the game without injection. I didn't notice any weird synchronization issues on my game but I realize that this could potentially cause some if we remove it outright for all which is why I made it an optional feature for DX12 only and enabled it by default to retain existing functionality.
P.S, your discord links in the readme/troubleshooting guide on all your repos has expired. :)