Merge pull request #9751 from vegaprotocol/fix-missing-party-sla-acco…

…unts

fix: add old snapshot compability

CHANGELOG.md

@@ -296,6 +296,7 @@
 - [9731](https://github.com/vegaprotocol/vega/issues/9731) - Allow team rewards to apply to all teams.
 - [9727](https://github.com/vegaprotocol/vega/issues/9727) - Initialize teams earlier to avoid panic.
 - [9541](https://github.com/vegaprotocol/vega/issues/9731) - Add filtering for party to the referral fees API.
+- [9751](https://github.com/vegaprotocol/vega/issues/9751) - Make sure that LP fee party accounts exists.
 
 ## 0.72.1
 

core/collateral/engine.go

@@ -938,7 +938,7 @@ func (e *Engine) transferFees(ctx context.Context, marketID string, assetID stri
 	responses := make([]*types.LedgerMovement, 0, len(transfers))
 
 	for _, transfer := range transfers {
-		req, err := e.getFeeTransferRequest(
+		req, err := e.getFeeTransferRequest(ctx,
 			transfer, makerFee, infraFee, liquiFee, marketID, assetID)
 		if err != nil {
 			e.log.Error("Failed to build transfer request for event",
@@ -2001,6 +2001,7 @@ func (e *Engine) MarginUpdateOnOrder(ctx context.Context, marketID string, updat
 }
 
 func (e *Engine) getFeeTransferRequest(
+	ctx context.Context,
 	t *types.Transfer,
 	makerFee, infraFee, liquiFee *types.Account,
 	marketID, assetID string,
@@ -2021,11 +2022,11 @@ func (e *Engine) getFeeTransferRequest(
 	}
 
 	partyLiquidityFeeAccount := func() (*types.Account, error) {
-		return getAccount(marketID, t.Owner, types.AccountTypeLPLiquidityFees)
+		return e.GetOrCreatePartyLiquidityFeeAccount(ctx, t.Owner, marketID, assetID)
 	}
 
 	bonusDistributionAccount := func() (*types.Account, error) {
-		return getAccount(marketID, systemOwner, types.AccountTypeLiquidityFeesBonusDistribution)
+		return e.GetOrCreateLiquidityFeesBonusDistributionAccount(ctx, marketID, assetID)
 	}
 
 	marginAccount := func() (*types.Account, error) {