Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement auction uncrossing for AMMs #11316

Merged
merged 1 commit into from
May 28, 2024
Merged

feat: implement auction uncrossing for AMMs #11316

merged 1 commit into from
May 28, 2024

Conversation

wwestgarth
Copy link
Contributor

@wwestgarth wwestgarth commented May 23, 2024 •
edited
Loading

closes #10539
closes #11283
closes #11323

@wwestgarth wwestgarth force-pushed the 10539-amm-auction-uncrossing branch 3 times, most recently from 6aa5598 to 6313e20 Compare May 24, 2024 10:29
@wwestgarth wwestgarth marked this pull request as ready for review May 24, 2024 11:37
@wwestgarth wwestgarth requested review from a team as code owners May 24, 2024 11:37
@wwestgarth wwestgarth force-pushed the 10539-amm-auction-uncrossing branch from 6313e20 to 204ac06 Compare May 28, 2024 09:10
EVODelavega
EVODelavega requested changes May 28, 2024
View reviewed changes
core/execution/amm/pool.go Outdated Show resolved Hide resolved
Jiajia-Cui
Jiajia-Cui previously approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@Jiajia-Cui Jiajia-Cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the feature tests look good

Jiajia-Cui
Jiajia-Cui previously approved these changes May 28, 2024
View reviewed changes
peterbarrow
peterbarrow previously approved these changes May 28, 2024
View reviewed changes
core/matching/orderbook.go Outdated Show resolved Hide resolved
core/matching/orderbook.go Outdated Show resolved Hide resolved
@wwestgarth wwestgarth dismissed stale reviews from peterbarrow and Jiajia-Cui via 58d92cc May 28, 2024 10:26
EVODelavega
EVODelavega previously approved these changes May 28, 2024
View reviewed changes
@cdummett cdummett mentioned this pull request May 28, 2024
Closed
@wwestgarth wwestgarth force-pushed the 10539-amm-auction-uncrossing branch from 58d92cc to 0fbb81f Compare May 28, 2024 12:20
@wwestgarth wwestgarth force-pushed the 10539-amm-auction-uncrossing branch from 0fbb81f to 839c15f Compare May 28, 2024 13:04
@wwestgarth wwestgarth mentioned this pull request May 28, 2024
Open
@jeremyletang jeremyletang merged commit 335f714 into develop May 28, 2024
16 checks passed
@jeremyletang jeremyletang deleted the 10539-amm-auction-uncrossing branch May 28, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EVODelavega EVODelavega EVODelavega approved these changes

@Jiajia-Cui Jiajia-Cui Jiajia-Cui left review comments

@peterbarrow peterbarrow peterbarrow left review comments

Assignees
No one assigned
Labels
no-changelog
Projects
None yet
Milestone
No milestone
5 participants
@wwestgarth @EVODelavega @peterbarrow @Jiajia-Cui @jeremyletang