feat: make batch market instruction errors programmatically usable #11537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candida-d
reviewed
Aug 7, 2024
| @@ -644,6 +660,8 @@ message TransactionResult { | |||
| message FailureDetails { | |||
| // Error message explaining the reason for the transaction failing processing | |||
| string error = 1; | |||
| // a map of the detailed errors if any | |||
There was a problem hiding this comment.
Suggested change
| // a map of the detailed errors if any | |
| // Map of the detailed errors, if any |
candida-d
previously approved these changes
Aug 7, 2024
jeremyletang
force-pushed
the
feature/map-errors
branch
from
355a8a3 to
7a95c09
Compare
candida-d
previously approved these changes
Aug 7, 2024
wwestgarth
previously approved these changes
Aug 7, 2024
jeremyletang
changed the title
jeremyletang
force-pushed
the
feature/map-errors
branch
from
7a95c09 to
64c789e
Compare
EVODelavega
approved these changes
Aug 8, 2024
Signed-off-by: Jeremy Letang <me@jeremyletang.com>
Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com>
Signed-off-by: Jeremy Letang <me@jeremyletang.com>
jeremyletang
force-pushed
the
feature/map-errors
branch
from
64c789e to
68b8964
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #11536