-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: implement an allow list on market for the sell side #11731
chore: implement an allow list on market for the sell side #11731
Conversation
775d16a
to
7c8069a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@voltaireChocolatine I’ll leave the feature review to someone else but I’ve corrected some doc strings for the APIs
A few things:
|
No, but I will remove the implementation of this feature for future markets as we do not plan to use it with these, and thinking about it, it doesn't makes sense at all in the context of future markets (I believe AMM as well are only available with future markets?).
I think base on my previous sentence, this is being answered.
Correct, we are still working on the tests, I've just submitted it for an early review by the vega team. |
5db461b
to
5ae2e12
Compare
@candida-d I've merged all your changes. |
5ae2e12
to
66d10bf
Compare
Signed-off-by: Voltaire Chocolatine <q7mbqtQKGpsfaPAHKpHJ5Dgdg6at3YBQzmR@proton.me>
66d10bf
to
ac37af8
Compare
Hi vega team, we've implemented a small feature to only allow a limited amount of key to be allowed to place order on the sell side of the book. This will be useful in some future markets that we plan to implement on nebula.
I realise we could keep this feature on our fork, but it would make life easier for our validators and for future maintenance if this was added in the main repo.
Happy to discuss further the reasons for the changes.