-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gradle 8.10.2 and test with Java 21 #15
base: master
Are you sure you want to change the base?
Conversation
Update to Java 21 requires update gradle version. |
@wmdietl This change seems needed for JDK 8 in this project. I am wondering how CF handle internal API like |
After this PR, I will also update the version of eisop CF. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes!
Just one small comment. Also, can you update to gradle 8.10.2 to make it current?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, if it's compatible with Java 21, can you add that to CI?
Done |
build.gradle
Outdated
} | ||
} | ||
} | ||
|
||
plugins { | ||
id "java" | ||
id "maven-publish" | ||
// https://github.com/tbroyer/gradle-errorprone-plugin | ||
// id 'net.ltgt.errorprone' version '3.1.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be uncommented? There are some other mentions of errorprone in the build file, so is it correctly running?
I updated everything in #16. |
@wmdietl Could you be more explicit what is I did not get what it is and I search for |
Map<String, Map<String, Map<String, String>>> operations = | ||
(Map<String, Map<String, Map<String, String>>>) | ||
atypeFactory.atomoton.get("operations"); | ||
Map<String, Map<String, String>> operations = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ao-senXiong This change is what I meant in #15 (comment) - it changes what is expected in the yaml file.
Close #14 if this get merged.