Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gradle 8.10.2 and test with Java 21 #15

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

Ao-senXiong
Copy link
Collaborator

@Ao-senXiong Ao-senXiong commented Aug 16, 2024

Close #14 if this get merged.

@Ao-senXiong Ao-senXiong requested a review from wmdietl August 18, 2024 18:55
@Ao-senXiong
Copy link
Collaborator Author

Update to Java 21 requires update gradle version.

@Ao-senXiong Ao-senXiong assigned wmdietl and unassigned Ao-senXiong Sep 7, 2024
@Ao-senXiong
Copy link
Collaborator Author

@wmdietl This change seems needed for JDK 8 in this project. I am wondering how CF handle internal API like com.sun.tools.javac.code.Symbol

@Ao-senXiong
Copy link
Collaborator Author

After this PR, I will also update the version of eisop CF.

@Ao-senXiong Ao-senXiong changed the title Update linear checker to date Update linear checker to gradle 8.10 and compatiable with Java 21 Sep 7, 2024
Copy link
Contributor

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!
Just one small comment. Also, can you update to gradle 8.10.2 to make it current?

build.gradle Outdated Show resolved Hide resolved
@wmdietl wmdietl assigned Ao-senXiong and unassigned wmdietl Oct 2, 2024
Copy link
Contributor

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if it's compatible with Java 21, can you add that to CI?

@Ao-senXiong
Copy link
Collaborator Author

Also, if it's compatible with Java 21, can you add that to CI?

Done

@Ao-senXiong Ao-senXiong requested a review from wmdietl October 2, 2024 15:58
@Ao-senXiong Ao-senXiong removed their assignment Oct 2, 2024
@wmdietl wmdietl changed the title Update linear checker to gradle 8.10 and compatiable with Java 21 Use gradle 8.10.2 and test with Java 21 Oct 2, 2024
build.gradle Outdated
}
}
}

plugins {
id "java"
id "maven-publish"
// https://github.com/tbroyer/gradle-errorprone-plugin
// id 'net.ltgt.errorprone' version '3.1.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be uncommented? There are some other mentions of errorprone in the build file, so is it correctly running?

@wmdietl wmdietl assigned Ao-senXiong and unassigned wmdietl Oct 2, 2024
@wmdietl
Copy link
Contributor

wmdietl commented Jan 16, 2025

I updated everything in #16.
Please take a look at that. I've filed a few issues.
The only thing in this PR that I didn't understand is the change to yaml. Can you create a test case that motivates that change?

@Ao-senXiong
Copy link
Collaborator Author

I updated everything in #16. Please take a look at that. I've filed a few issues. The only thing in this PR that I didn't understand is the change to yaml. Can you create a test case that motivates that change?

@wmdietl Could you be more explicit what is the change to yaml?

I did not get what it is and I search for yaml. If you mean the library, there is no change.
image
If you mean the .yml, I think it is just updating the versions.

Map<String, Map<String, Map<String, String>>> operations =
(Map<String, Map<String, Map<String, String>>>)
atypeFactory.atomoton.get("operations");
Map<String, Map<String, String>> operations =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ao-senXiong This change is what I meant in #15 (comment) - it changes what is expected in the yaml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants