Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/interface name lower #672

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

hohmannr
Copy link
Contributor

@hohmannr hohmannr commented Jul 11, 2023

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Golang used when building/testing:

  • 1.11
  • 1.12
  • 1.13
  • 1.14
  • 1.15
  • 1.16
  • 1.17
  • 1.18
  • 1.19
  • 1.20

How Has This Been Tested?

Added an minimal invasive test for the templating variables in outputter_test.go to the existing test case.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: hohmannr <raphael.hohmann@tuta.io>
Signed-off-by: hohmannr <raphael.hohmann@tuta.io>
Signed-off-by: hohmannr <raphael.hohmann@tuta.io>
@LandonTClipp
Copy link
Collaborator

I'm honestly shocked you didn't find more spelling errors! This looks good, thanks for the PR.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 75.00000% and project coverage change: +0.02222 🎉

Comparison is base (b5592d6) 75.26978% compared to head (6e6efc2) 75.29200%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master        #672         +/-   ##
===================================================
+ Coverage   75.26978%   75.29200%   +0.02222%     
===================================================
  Files              9           9                 
  Lines           2224        2226          +2     
===================================================
+ Hits            1674        1676          +2     
  Misses           412         412                 
  Partials         138         138                 
Impacted Files Coverage Δ
pkg/config/config.go 70.56452% <0.00000%> (ø)
pkg/outputter.go 62.99559% <100.00000%> (+0.32891%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LandonTClipp LandonTClipp merged commit 8c06cfc into vektra:master Jul 11, 2023
5 checks passed
@hohmannr hohmannr deleted the feat/interface-name-lower branch July 12, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants