feat: calculate updated claimable unstaked fees in LpSugar #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas
reviewed
Nov 15, 2023
contracts/LpSugar.vy
Outdated
| claimable_delta1: uint256 = pool.index1() - pool.supplyIndex1(_account) | ||
|
|
||
| if claimable_delta0 > 0: | ||
| claimable0 += (acc_balance * claimable_delta0) / 10**18 |
There was a problem hiding this comment.
We should probably use pool.decimals() here instead of the hardcoded 10**18
contracts/LpSugar.vy
Outdated
| @@ -353,6 +357,17 @@ def _byData(_data: address[3], _account: address) -> Lp: | |||
| token0: IERC20 = IERC20(pool.token0()) | |||
| token1: IERC20 = IERC20(pool.token1()) | |||
| gauge_alive: bool = self.voter.isAlive(gauge.address) | |||
| acc_balance: uint256 = pool.balanceOf(_account) | |||
There was a problem hiding this comment.
I'm a bit concerned of the gas usage now that we're introducing these extra calls, should we skip fully the balance and claimable calculations if the _account is 0x0...00 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform same calculation that pool._updateFor does to fetch updated claimable unstaked fees for user