Fix Windows path resolution causing duplicate drive letter#3
Open
robwent wants to merge 1 commit intovelohost:mainfrom
Open
Fix Windows path resolution causing duplicate drive letter#3robwent wants to merge 1 commit intovelohost:mainfrom
robwent wants to merge 1 commit intovelohost:mainfrom
Conversation
On Windows, `new URL(dir).pathname` returns `/C:/path/to/dist/` which gets prepended with the cwd by `readdirSync`, producing an invalid path like `C:\C:\path\to\dist\`. Use `fileURLToPath()` instead, which correctly converts file:// URLs to platform-appropriate paths on both Windows and Linux. Fixes velohost#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
new URL(dir).pathnamereturns/C:/path/to/dist/which gets prepended with the cwd byreaddirSync, producing an invalid path likeC:\C:\path\to\dist\.Use
fileURLToPath()instead, which correctly converts file:// URLs to platform-appropriate paths on both Windows and Linux.Fixes #2