Update create-image.sh add missing fdisk in WSL #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got the snapdragon_7c_woa working with this image but fdisk was missing in WSL so it may be usefull to have it (script complains about it). not sure if it's the good place thought
Author
|
would be nice to add it or place requirements where it need to be to create the image without script complain |
Collaborator
|
sorry - i did not check for new pull requests for a while and thus it got lost a bit ... i think the proper place would be https://github.com/hexdump0815/imagebuilder/blob/main/scripts/prepare.sh maybe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got the snapdragon_7c_woa working with this image but fdisk was missing in WSL so it may be usefull to have it (script complains about it). not sure if it's the good place thought