Drop pysimplesoap #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead implement the required SOAP functionility by hand. Debbugs' SOAP implementation is archaic/quirky enough that most SOAP libraries have a hard time communicating with it.
|
Hey @pdewacht, thank you very much, this is really amazing! Your contribution goes well beyond from what I initial anticipated! Before this can be merged I need to do some tests with the reportbug maintainers and check if they spot any issues. Would you be in general open for support in case any new SOAP related issues come up? |
|
FYI: Your changes plus some future fixes that may pop up, live in this branch for now until testing with reportbug maintainers is concluded and we can merge: https://github.com/venthur/python-debianbts/tree/drop-pysimplesoap |
|
FYI, I've just uploaded your version to debian/experimental in agreement with the reportbug maintainers. I'll let it sit there for a while and see if we get any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my email last week, I suggested not using a SOAP library and instead implementing it by hand. (debbugs's SOAP server is archaic/quicky enough that no SOAP library is going to handle it very well.)
This is what that would look like. It has no dependencies beyond the Python stdlib, and it's barely longer than the original code using pysimplesoap.