Merge pull request #1381 from veraPDF/rule_tags

Fix NullPointerException for rule without tags
veraPDF · Oct 12, 2023 · 888dafc · 888dafc
2 parents 0be9838 + ea13739
commit 888dafc
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/core/src/main/java/org/verapdf/processor/reports/ValidationDetailsImpl.java b/core/src/main/java/org/verapdf/processor/reports/ValidationDetailsImpl.java
@@ -146,16 +146,21 @@ static ValidationDetails fromValues(final ValidationResult result, boolean logPa
 					assertionMap.get(rule.getRuleId()), logPassedChecks, failedChecksMap.get(rule.getRuleId()), rule.getTags()) :
 				RuleSummaryImpl.uncheckedInstance(rule.getRuleId(), rule.getDescription(), rule.getObject(), rule.getTest(), rule.getTags());
 			failedChecks += summary.getFailedChecks();
+			Set<String> summaryTags = summary.getTags();
 			if (summary.getRuleStatus() == Status.PASSED) {
 				passedRules++;
 				if (logPassedChecks) {
 					ruleSummaries.add(summary);
-					tags.addAll(summary.getTags());
+					if (summaryTags != null) {
+						tags.addAll(summaryTags);
+					}
 				}
 			} else {
 				failedRules++;
 				ruleSummaries.add(summary);
-				tags.addAll(summary.getTags());
+				if (summaryTags != null) {
+					tags.addAll(summaryTags);
+				}
 			}
 		}
 		int passedChecks = result.getTotalAssertions() - failedChecks;