feat: changed profile identifiers from HTTP URLs to tag URIs (RFC 4151) #223
+452
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PSA profiles now use tag:trustedcomputinggroup.org,2025 authority - CCA profiles now use tag:arm.com,2025 authority - Added comprehensive test coverage for URI validation - Added package documentation with usage examples Signed-off-by: Sukuna0007Abhi <appsonly310@gmail.com>
Sukuna0007Abhi
changed the title
Contributor
Author
|
Thanks sir @setrofim |
Contributor
Author
|
Pls review sir @yogeshbdeshpande sir @thomas-fossati |
- Added RFC 4151 tag URI validation to PSA and CCA profile packages - Replaced .String() with .Get() method for eat.Profile API - Updated all test cases to use new tag URI format - Replaced existing HTTP URLs (https://arm.com/psa/iot/2.0.0) with tag URIs - All validation and tests passing Fixes veraison#110 Signed-off-by: Sukuna0007Abhi <appsonly310@gmail.com>
Contributor
Author
|
Pls review sir @setrofim @yogeshbdeshpande |
setrofim
requested changes
Oct 13, 2025
| var err error | ||
|
|
||
| // Validate and create Token Profile | ||
| if err = validateTagURI("tag:arm.com,2025:cca-token"); err != nil { |
Contributor
There was a problem hiding this comment.
What is the prupose of this check? You're validating a static string (ditto for all validateTagURI() calls bellow -- this function can probably be removed).
| var err error | ||
|
|
||
| // Validate and create Token Profile | ||
| if err = validateTagURI("tag:trustedcomputinggroup.org,2025:psa-token"); err != nil { |
Contributor
There was a problem hiding this comment.
As with CCA, this check is pointless for a static string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed profile identifiers from HTTP URLs to tag URIs (RFC 4151)
PSA profiles now use tag:trustedcomputinggroup.org,2025 authority
CCA profiles now use tag:arm.com,2025 authority
Added comprehensive test coverage for URI validation
Added package documentation with usage examples
Fixes #110