fix: skip symlink optimization in Volta environment #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #324
When installing
agent-browservia Volta, the postinstall symlink optimization creates broken symlinks because Volta uses a staging directory that gets renamed after postinstall completes.Changes
Added Volta environment detection at the beginning of both
fixUnixSymlink()andfixWindowsShims()functions:Why This Works
VOLTA_HOMEenvironment variable is always set when running under VoltaTesting
Manual Verification
Unit Tests Added
Added comprehensive test suite in
test/postinstall.test.tscovering:shouldSkipBinOptimizationlogic - Tests VOLTA_HOME detection with various values/tmp/vs/tools/)$ pnpm vitest run test/postinstall.test.ts ✓ test/postinstall.test.ts (11 tests) 8ms Test Files 1 passed (1) Tests 11 passed (11)Root Cause Analysis
The issue occurs because:
$VOLTA_HOME/tmp/image/packages/.tmpXXX/npm prefix -greturns this temp pathfixUnixSymlink()creates symlink pointing to staging directory$VOLTA_HOME/tools/image/packages/{name}/The fix detects Volta environment and skips the optimization, letting Volta's shim system handle binary invocation.