Fix dialog dismiss parsing in CLI #361
Open
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s going on
The CLI help and README list
dialog dismissas a valid subcommand, but the dialog parser only handlesaccept. Any other value (includingdismiss) falls intoUnknownSubcommandand the CLI exits with an error.Fix
Add a
dismissbranch to the dialog parser to emit the correct command JSON:This matches the existing protocol and runtime support:
dismiss: https://github.com/vercel-labs/agent-browser/blob/main/src/protocol.ts#L198-L202Why this is safe
It only changes CLI parsing for
dialogand doesn’t touch the protocol or Playwright behavior.Testing
Not run (no CLI tests in repo).