fix: auto-start daemon on Windows to resolve 'Daemon failed to start' #362
+160
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix windows daemon startup and port calculation inconsistency
Contributor
|
@0okay is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| async function ensureDaemonRunning() { | ||
| if (platform() !== 'win32') return; | ||
|
|
||
| const agentDir = join(homedir(), '.agent-browser'); |
Contributor
There was a problem hiding this comment.
Port file path mismatch between daemon writer and wrapper reader causes daemon detection to always fail on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical issue on Windows where the agent-browser daemon fails to start automatically when running CLI commands like 'agent-browser open'.
The Issue
On Windows, the native binary wrapper mechanism relied on the daemon being already running or properly spawned, but due to platform differences, the automatic daemon startup was failing silently, leading to:
\Daemon failed to start (socket: ...)\
The Fix
This ensures a seamless experience for Windows users (via
px\ or global install) while maintaining compatibility with other platforms.