feat: add AGENT_BROWSER_VIEWPORT env var #380
Conversation
|
@Sanchay-T is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f62871e1a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/daemon.ts
Outdated
| const match = value.match(/^(\d+)[x,](\d+)$/); | ||
| if (!match) return undefined; | ||
| return { width: parseInt(match[1], 10), height: parseInt(match[2], 10) }; |
There was a problem hiding this comment.
parseViewportEnv() currently accepts 0 values (for example AGENT_BROWSER_VIEWPORT=0x720) because the regex allows any digits, then forwards that viewport to browser.launch() during daemon auto-launch. Playwright viewport sizes must be positive, so this causes auto-launch to throw on the first non-launch command and effectively breaks the daemon for that session instead of ignoring invalid env input and falling back to defaults.
Useful? React with 👍 / 👎.
The daemon auto-launch hardcodes 1280x720, with no way to set a default viewport without an explicit launch command. This adds support for the AGENT_BROWSER_VIEWPORT env var (e.g., "1920x1080" or "1920,1080") so users can persist their preferred viewport size across sessions.
Sanchay-T
force-pushed
the
feat/viewport-env-var
branch
from
5f62871 to
8b1d739
Compare
1 participant
Summary
AGENT_BROWSER_VIEWPORTenv var to set default viewport size for auto-launched browser sessions (e.g.,1920x1080or1920,1080)parseViewportEnv()helper insrc/daemon.tswith full unit test coverage0x720) to avoid Playwright errorsMotivation
The daemon auto-launch hardcodes
1280x720with no way to persist a preferred viewport. Users had to send an explicitlaunchcommand orset viewporton every session. This follows the same pattern asAGENT_BROWSER_EXECUTABLE_PATH,AGENT_BROWSER_SESSION, etc.Changes
src/daemon.tsparseViewportEnv()+ pass viewport to auto-launchsrc/daemon.test.tsREADME.mdTest plan
AGENT_BROWSER_VIEWPORT=1920x1080→ browser reportsinnerWidth:1920, innerHeight:10801280x7200x1080,1920x0,0x0→ rejected, falls back to defaultWxH,W,H), invalid/empty/undefined inputs