fix: forward environment variables to browser subprocess #387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #369
When launching a browser on Linux in
--headedmode (e.g., via VNC or Xvfb), Playwright'slaunch()andlaunchPersistentContext()calls did not receive the parent process's environment variables. This caused theDISPLAYvariable (and any other environment variables) to be missing in the browser subprocess, resulting in the error:Root Cause
Playwright's
launch()accepts anenvoption. When omitted, Playwright usesprocess.envby default in most cases, but in certain deployment scenarios (Docker, VNC, Xvfb), the environment is not correctly inherited by the browser subprocess. Explicitly passingenv: { ...process.env }ensures all environment variables—includingDISPLAY—are forwarded reliably.Changes
Added
env: { ...process.env }to all three browser launch calls insrc/browser.ts:launcher.launchPersistentContext()— extensions pathlauncher.launchPersistentContext()— profile pathlauncher.launch()— regular ephemeral browserImpact
This fix affects Linux users running agent-browser in headed mode, particularly in:
DISPLAYor other environment variables need to reach the browser process