fix: prevent native file picker dialog during uploads #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@NikhilGaddam is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Author
|
Fixed the CSS selector issue! Now using |
Resolve relative file paths to absolute before passing to setInputFiles. Playwright's setInputFiles already handles file uploads without opening the native file dialog, so no CDP workaround is needed. Fixes vercel-labs#192 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
NikhilGaddam
force-pushed
the
fix-upload-native-dialog
branch
from
3668b4e to
7577da2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix file upload with relative paths
The upload command fails when relative file paths are passed because Playwright's
setInputFilesexpects absolute paths. This resolves relative paths to absolute before passing them tosetInputFiles.The previous approach of using CDP
DOM.setFileInputFilesto avoid the native file dialog is unnecessary — Playwright'ssetInputFilesalready bypasses the native dialog entirely. The CDP approach actually introduced a regression: cached CDP sessions become stale after page navigations, causingTarget page, context or browser has been closederrors.This keeps the fix minimal: just add path resolution while staying with Playwright's built-in API.
Fixes #192