fix: preserve chrome-extension:// and chrome:// URL schemes in CLI #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CLI's URL normalization was auto-prepending https:// to any URL whose scheme wasn't in the allowlist (http, https, about, data, file). This caused chrome-extension:// URLs to become https://chrome-extension//... which fails with ERR_NAME_NOT_RESOLVED, preventing navigation to extension pages (popup, side panel, options). Add chrome-extension:// and chrome:// to the open command's scheme allowlist, and update the record start/restart commands to preserve any URL that already contains :// instead of only checking for http. Fixes vercel-labs#409
Contributor
|
@rsiddle is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI's URL normalization was auto-prepending https:// to any URL whose scheme wasn't in the allowlist (http, https, about, data, file). This caused chrome-extension:// URLs to become
https://chrome-extension//... which fails with ERR_NAME_NOT_RESOLVED, preventing navigation to extension pages (popup, side panel, options).
Add chrome-extension:// and chrome:// to the open command's scheme allowlist, and update the record start/restart commands to preserve any URL that already contains :// instead of only checking for http.
Fixes #409