feat: add support for git branch via ssh and shorthand URLs#393
Open
dingruoqian99 wants to merge 1 commit intovercel-labs:mainfrom
Open
feat: add support for git branch via ssh and shorthand URLs#393dingruoqian99 wants to merge 1 commit intovercel-labs:mainfrom
dingruoqian99 wants to merge 1 commit intovercel-labs:mainfrom
Conversation
Contributor
Author
|
This PR resolves #394 |
Contributor
Author
|
@quuu trouble you to take a look at this |
Collaborator
|
@dingruoqian99 im currently working on moving away from needing the tree folder hash (using the github API) which would also remove the need to hardcode and check main/master/ default branch Let me see if i can go ahead with the more future proof change, before merging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added support for pulling from specific git branches using the
#branchsuffix in SSH URLs and GitHub shorthand.Problem/Background
The CLI previously only supported branch selection for GitHub/GitLab HTTPS URLs formatted like
.../tree/branch. Users could not specify a branch when using SSH URLs or shorthand syntax, which is essential for private repositories or specific development branches.Solution
parseSourceto recognize the#fragment as a git ref (branch/tag/commit).fetchSkillFolderHashto use the specified branch when checking for updates on GitHub.Testing
tests/source-parser.test.ts