Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch 14 - A11y eslint config #304

Closed
ibanlopez opened this issue Oct 30, 2023 · 1 comment · Fixed by #305
Closed

Ch 14 - A11y eslint config #304

ibanlopez opened this issue Oct 30, 2023 · 1 comment · Fixed by #305

Comments

@ibanlopez
Copy link

First things first, I want to thank you all the team involved in this amazing learning resource.

https://nextjs.org/learn/dashboard-app/improving-accessibility#using-the-eslint-accessibility-plugin-in-nextjs

in this part of the docs which explain how to config the eslint plugin, it doesn't actually create the .eslintrc.json files when running the script: "next lint".

Problem description

It points explains the next steps literally:

  1. npm run lint
  2. You should see the following warning:

./app/ui/invoices/table.tsx 45:25 Warning: Image elements must have an alt prop, either with meaningful text, or an empty string for decorative images. jsx-a11y/alt-text

But this doesn't happen because running the script actually installs 'eslint' and 'eslint-config-next' devDdependencies, but this does not creaate the .eslintrc.json file.

Questions

It's not quite clear at this point whether we should follow the eslint config steps in the docs or it is intended that we should creaate manually this file and proceed with the docs for configuring.

Maybe this should be noted or point to this step between 1 and 2 steps on the chapter 14 documentaation.

Thank you so much for this resource anyways.

@delbaoliveira
Copy link
Collaborator

Thank you for raising this @ibanlopez 🙏🏼 . This issue has been addressed here: #305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants