Fix ESLint #305
Merged
Fix ESLint #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The user will be adding it during the course
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leerob
approved these changes
Oct 30, 2023
This was referenced Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #304
This PR fixes an issue with running eslint in the
starter-exampleandfinal-examplefor Chapter 14. . Since we're setting the eslint config at the root ofnext-learn, runningnpm run eslintin thestarter-examplerepo didn't automatically install the necessary packages and create theeslintrc.jsonfile.starter-exampleandfinal-examplerepos.eslintrc.jsonfilesWhen running
next-learnfrom the root, this setup will not work, and will give the following error:However, since the user will only clone the
starter-example, this should work for their local repo.