Fix pagination bugs and refactor/abstract styling logic #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
delbaoliveira
changed the title
delbaoliveira
commented
Oct 9, 2023
Comment on lines
+7
to
+9
| searchParams?: { | ||
| query?: string; | ||
| page?: string; |
There was a problem hiding this comment.
This is not related, just cleaning up TS.
emilkowalski
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the pagination bugs:
pointer-events-noneto disable arrows for the first and last pages, but this only disables mouse events - keyboard users could navigate topage=0orpage=totalPages + 1. This PR truly disables them by rendering a<div>instead of a<Link>. It also means we're not passing a href to disabled links.I've also extracted away the logic into separate components to make it easier for the user to update the
<Pagination>component.