Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove incorrect labels in radio groups #269

Merged
merged 3 commits into from
Oct 30, 2023
Merged

fix: remove incorrect labels in radio groups #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cba127
fix: remove incorrect labels in radio groups
morellodev Oct 28, 2023
c9bca14
Merge branch 'main' into fix/form-a11y
delbaoliveira Oct 30, 2023
61acdab
Merge branch 'main' into fix/form-a11y
delbaoliveira Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dashboard/final-example/app/ui/invoices/create-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@ export default function Form({ customers }: { customers: CustomerField[] }) {
</div>

{/* Invoice Status */}
<div>
<label htmlFor="status" className="mb-2 block text-sm font-medium">
<fieldset>
<legend className="mb-2 block text-sm font-medium">
Set the invoice status
</label>
</legend>
<div className="rounded-md border border-gray-200 bg-white px-[14px] py-3">
<div className="flex gap-4">
<div className="flex items-center">
Expand Down Expand Up @@ -140,7 +140,7 @@ export default function Form({ customers }: { customers: CustomerField[] }) {
))}
</div>
) : null}
</div>
</fieldset>

{state.message ? (
<div aria-live="polite" className="my-2 text-sm text-red-500">
Expand Down
8 changes: 4 additions & 4 deletions dashboard/final-example/app/ui/invoices/edit-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ export default function EditInvoiceForm({
</div>

{/* Invoice Status */}
<div>
<label htmlFor="status" className="mb-2 block text-sm font-medium">
<fieldset>
<legend className="mb-2 block text-sm font-medium">
Set the invoice status
</label>
</legend>
<div className="rounded-md border border-gray-200 bg-white px-[14px] py-3">
<div className="flex gap-4">
<div className="flex items-center">
Expand Down Expand Up @@ -150,7 +150,7 @@ export default function EditInvoiceForm({
))}
</div>
) : null}
</div>
</fieldset>

{state.message ? (
<div aria-live="polite" className="my-2 text-sm text-red-500">
Expand Down
8 changes: 4 additions & 4 deletions dashboard/starter-example/app/ui/invoices/create-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ export default function Form({ customers }: { customers: CustomerField[] }) {
</div>

{/* Invoice Status */}
<div>
<label htmlFor="status" className="mb-2 block text-sm font-medium">
<fieldset>
<legend className="mb-2 block text-sm font-medium">
Set the invoice status
</label>
</legend>
<div className="rounded-md border border-gray-200 bg-white px-[14px] py-3">
<div className="flex gap-4">
<div className="flex items-center">
Expand Down Expand Up @@ -98,7 +98,7 @@ export default function Form({ customers }: { customers: CustomerField[] }) {
</div>
</div>
</div>
</div>
</fieldset>
</div>
<div className="mt-6 flex justify-end gap-4">
<Link
Expand Down
8 changes: 4 additions & 4 deletions dashboard/starter-example/app/ui/invoices/edit-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@ export default function EditInvoiceForm({
</div>

{/* Invoice Status */}
<div>
<label htmlFor="status" className="mb-2 block text-sm font-medium">
<fieldset>
<legend className="mb-2 block text-sm font-medium">
Set the invoice status
</label>
</legend>
<div className="rounded-md border border-gray-200 bg-white px-[14px] py-3">
<div className="flex gap-4">
<div className="flex items-center">
Expand Down Expand Up @@ -108,7 +108,7 @@ export default function EditInvoiceForm({
</div>
</div>
</div>
</div>
</fieldset>
</div>
<div className="mt-6 flex justify-end gap-4">
<Link
Expand Down
Loading