Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add formatting and fixing README of dashboard starter/final example #271

Closed
wants to merge 0 commits into from

Conversation

moelzanaty3
Copy link
Contributor

This fixes

  • README for the dashboard starter/final example typo and formatting
  • Add the prettier configuration to have all code formatted
  • Fix importing order and remove unused-imports

@vercel
Copy link

vercel bot commented Oct 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-learn-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2023 7:32pm
next-seo-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2023 7:32pm

@vercel
Copy link

vercel bot commented Oct 28, 2023

Someone is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@delbaoliveira
Copy link
Collaborator

delbaoliveira commented Oct 30, 2023

Thank you for looking into this @moelzanaty3 😄

There are a couple of changes on this PR, and it would be easier to make smaller, grouped changes.

  • I like the idea of adding "prettier-plugin-tailwindcss" and the prettier config file.
  • I have some reservations about adding @vercel/style-guide as this would lead to many changes in the code that we'd have to update in the course code snippets.
  • Could you please open a PR that only includes the prettier changes? And another for the readme updates. And we can merge. 🙏🏼

@moelzanaty3
Copy link
Contributor Author

moelzanaty3 commented Oct 30, 2023

@delbaoliveira thanks for taking the time to review the changes, I opened a 2 PR

[x] one for updating README #316
[x] another one for a prettier #315

will keep you updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants