Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PPR flag, add noStore to fetchInvoiceById #307

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Remove PPR flag, add noStore to fetchInvoiceById #307

merged 2 commits into from
Oct 30, 2023

Conversation

delbaoliveira
Copy link
Collaborator

@delbaoliveira delbaoliveira commented Oct 30, 2023 •
edited
Loading

Fixes: #277

  • Remove PPR flag as it doesn't work in production yet
  • Add noStore to fetchInvoiceById to fetch fresh data when the user visits the edit invoice route.
  • Update code snippet in the chapter: https://github.com/vercel/front/pull/26672

I don't think we need to call revalidatePath to purge the client-side router cache, but if this issue happens again, we can explore using revalidateTag instead.

@vercel
Copy link

vercel bot commented Oct 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-learn-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 0:34am
next-learn-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 0:34am
next-seo-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 0:34am

@delbaoliveira delbaoliveira changed the title Remove PPR flag Remove PPR flag, review data fetching functions Oct 30, 2023
@delbaoliveira delbaoliveira changed the title Remove PPR flag, review data fetching functions Remove PPR flag, don't store fetchInvoicesbyId Oct 30, 2023
@delbaoliveira delbaoliveira changed the title Remove PPR flag, don't store fetchInvoicesbyId Remove PPR flag, add noStore Oct 30, 2023
@delbaoliveira delbaoliveira changed the title Remove PPR flag, add noStore Remove PPR flag, add noStore to fetchInvoiceById` Oct 30, 2023
@delbaoliveira delbaoliveira changed the title Remove PPR flag, add noStore to fetchInvoiceById` Remove PPR flag, add noStore to fetchInvoiceById Oct 30, 2023
@delbaoliveira delbaoliveira mentioned this pull request Oct 30, 2023
Closed
@leerob leerob merged commit e8ba4d3 into main Oct 30, 2023
6 checks passed
@leerob leerob deleted the remove-ppr-flag branch October 30, 2023 14:29
This was referenced Oct 30, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leerob leerob leerob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revalidate path needs to be updated in the edit section
2 participants
@delbaoliveira @leerob