Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove old team members #744

Merged
merged 1 commit into from
Jun 23, 2024
Merged

Chore: Remove old team members #744

merged 1 commit into from
Jun 23, 2024

Conversation

delbaoliveira
Copy link
Collaborator

Remove old team members who are no longer at Vercel, and remove unused images.

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-learn-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 1:15pm
next-learn-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 1:15pm
next-seo-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 1:15pm

@delbaoliveira delbaoliveira marked this pull request as ready for review June 11, 2024 17:33
@leerob leerob merged commit f8d9f39 into main Jun 23, 2024
7 checks passed
@leerob leerob deleted the learn-89sd branch June 23, 2024 16:33
@FranciscoCasado
Copy link

Hi, this PR broke seeds.

There were 8 customers, but now there are only 7, which breaks the relation in line 89 of placeholder_data.js.

seed.js throws this error:

customer_id: customers[7].id,
                          ^
TypeError: Cannot read properties of undefined (reading 'id') at Object.<anonymous> 

I can make a PR, but I guess that you prefer to come up with names of your own for that sample data. Should I dump this to issues?

@leerob
Copy link
Member

leerob commented Jun 24, 2024

It's being updated here! #764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants