Skip to content

Conversation

@cmcWebCode40
Copy link
Contributor

@cmcWebCode40 cmcWebCode40 commented Dec 8, 2022

Tasks

  • Completed Claim badge Flow Screens
  • Refactored manage wallets action sheets component
  • Develop badges/badge list and alert components
  • Modified existing address list component .

closes #764

Note: No actual functionalities have been implemented.

Note from PR #874
Closes #868
Depends on Data connector server update: verida/data-connector-server#47

Demo

https://www.loom.com/share/6c8a592324d941c7a0317a880f19bb67

- claim badges screen
- Alert component
- claim badge status screen
- claim single badge screen
- bages list component
#764
- Refactor manage wallets action sheet modal
- claim badge UI styles fixes
- Component styles fix
- Eslint Fix
#764
@cmcWebCode40 cmcWebCode40 self-assigned this Dec 8, 2022
@aurelticot
Copy link
Member

@cmcWebCode40 following our conversation last time about the difference between the "Select Wallet" modal and the "Select Address" modal which are supposed to be relatively similar but had some differences in the Figma design, Oleksander made an update so they do have a similar design and behaviour.
The only difference is one list wallets, why other list addresses. They can definite=ively share a fair bit of common code to be factorised.

Can you look at the Figma and apply the changes.
Thanks

I will continue the review afterwards

- Added a selector to filter list of account address list
- Added badge backgorund image
- Change name of claim badge screens
- Modified the Addresslist components
#764
- modified alert component logic
- removed custom styles and also change modal close icon
- Add verida one url constant
- modified banner component profile screen link
#764
@cmcWebCode40
Copy link
Contributor Author

@aurelticot ,

i have completed the requested changes , please can you review ?

@aurelticot aurelticot linked an issue Apr 27, 2023 that may be closed by this pull request
6 tasks
@aurelticot aurelticot removed a link to an issue Apr 27, 2023
6 tasks
@aurelticot
Copy link
Member

Rely on #874

@aurelticot aurelticot modified the milestones: 0.3.37, 0.x.x May 5, 2023
…badges-flow

# Conflicts:
#	src/components/WalletList/types.ts
#	src/components/WalletModal/ImportWalletModal.tsx
#	src/constants/url.js
#	src/navigation/types.ts
#	src/pages/Wallets/ManageWallets.tsx
#	src/pages/Wallets/SingleWallet.tsx
#	src/reduxStore/wallet/selectors.js
#	src/styles/button.js
…ure/764-claim-badges-flow

# Conflicts:
#	package.json
#	src/pages/Assets/Collectibles.tsx
#	src/pages/Data/CredentialDataItem.tsx
#	yarn.lock
@aurelticot aurelticot changed the title Feature/764 claim badges flow UI Feature/764 claim badges flow May 24, 2023
@aurelticot aurelticot changed the title Feature/764 claim badges flow Feature/764 Claim badges flow May 24, 2023
@aurelticot aurelticot changed the title Feature/764 Claim badges flow Feature/764 Claim badges feature May 24, 2023
@aurelticot aurelticot changed the title Feature/764 Claim badges feature Feature/764 Claim Badge feature May 24, 2023
…badges-flow

# Conflicts:
#	src/navigation/MainNavigator.tsx
@aurelticot aurelticot modified the milestones: 0.x.x, unscheduled May 25, 2023
@andy-verida
Copy link
Contributor

andy-verida commented Jun 5, 2023

Things I work on:

  • List claimable badges
  • List connections that suggest user connect to claim more badges
  • Try to claim the Discord Account badge(but fail)
  • Clean up and organize source code(to be in the features folder)
  • Badges list components https://github.com/orgs/verida/projects/10?pane=issue&itemId=29199503
    - This is mostly complete, will need to mix and render real data from the data-connector and SBTs manager. I will continue to work on this once the data is ready.

@aurelticot aurelticot removed this from the unscheduled milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support minting SBTs Minting badges in the Vault Claim badges flow

5 participants