-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/764 Claim Badge feature #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@cmcWebCode40 following our conversation last time about the difference between the "Select Wallet" modal and the "Select Address" modal which are supposed to be relatively similar but had some differences in the Figma design, Oleksander made an update so they do have a similar design and behaviour. Can you look at the Figma and apply the changes. I will continue the review afterwards |
- modified alert component logic - removed custom styles and also change modal close icon - Add verida one url constant - modified banner component profile screen link #764
|
i have completed the requested changes , please can you review ? |
- updated claimbadge screen params types
|
Rely on #874 |
…badges-flow # Conflicts: # src/components/WalletList/types.ts # src/components/WalletModal/ImportWalletModal.tsx # src/constants/url.js # src/navigation/types.ts # src/pages/Wallets/ManageWallets.tsx # src/pages/Wallets/SingleWallet.tsx # src/reduxStore/wallet/selectors.js # src/styles/button.js
…ure/764-claim-badges-flow # Conflicts: # package.json # src/pages/Assets/Collectibles.tsx # src/pages/Data/CredentialDataItem.tsx # yarn.lock
…badges-flow # Conflicts: # src/navigation/MainNavigator.tsx
…badges-flow # Conflicts: # src/pages/Connections/SingleConnection.js
|
Things I work on:
|
Tasks
closes #764
Note: No actual functionalities have been implemented.
Note from PR #874
Closes #868
Depends on Data connector server update: verida/data-connector-server#47
Demo
https://www.loom.com/share/6c8a592324d941c7a0317a880f19bb67