fix: little Ascend NPU implementation bug fix #5246
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the npu-smi command to retrieve version information more broadly and modified version parsing logic. Previous method need higher permission (sudo), causing error in cloud server sometimes .
Because `override_model_config` in **fsdp_workers.py** changes the model’s `attn_implementation` to **Flash Attention**, which is not currently supported on **Ascend**, the NPU must use **SDPA** or **eager attention** here instead.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in device detection for Ascend NPUs and updates a launch command in the documentation. The change to verl/utils/device.py makes the npu-smi command more general, which is a good improvement for compatibility. However, the logic for parsing the software version has become fragile. I've provided a suggestion to make the version parsing more robust using a regular expression to prevent potential issues with incorrect version detection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?