Skip to content

[vllm] feat: add model saving func to dump vllm state_dict before and after update weights#5278

Open
RobotGF wants to merge 2 commits intoverl-project:mainfrom
RobotGF:add_vllm_dump_utils
Open

[vllm] feat: add model saving func to dump vllm state_dict before and after update weights#5278
RobotGF wants to merge 2 commits intoverl-project:mainfrom
RobotGF:add_vllm_dump_utils

Conversation

@RobotGF
Copy link
Contributor

@RobotGF RobotGF commented Feb 11, 2026

What does this PR do?

Add a debug func to dump vllm model state_dict by set VERL_VLLM_WEIGHT_SAVE_DIR

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a debugging feature to save the vLLM model's state dictionary to safetensors files before and after weight updates. This is controlled by the VERL_VLLM_WEIGHT_SAVE_DIR environment variable. The implementation is straightforward. My review includes a suggestion to make the feature more robust by handling cases where the safetensors library might not be installed, preventing potential crashes in worker processes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant