Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic INVITE dialog NOTIFY as basis for talk & hold NOTIFY #748

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

markusatm
Copy link
Contributor

This PR is about implement support for talk and hold NOTIFY in a generic way.

Talk and hold NOTIFY are SIP NOTIFYs that are sent on a INVITE dialog. It's based on a specification originally written by Broadsoft and now maintained by Cisco.
It is a de-facto industry standard which has been implemented by several more PBX manufacturers and is based on RFC 3265.
A detailed feature explanation can be found in the specification SIPAccessSideExtensionsInterfaceSpec sections 6 and 7: https://pubhub.devnetcloud.com/media/broadsoft-docs/docs/pdf/BW-SIPAccessSideExtensionsInterfaceSpec.pdf

The change in this pull request allows the user to set an Allow-Events SIP header for a list (string array) of NOTIFY events.
This can be set:

  • In the CallOptions for outgoing calls.
  • In the AnswerOptions when answering incoming calls.
  • Via set allow_events before a 180 Ringing gets sent on an incoming call (important!).

If a list of events is provided JsSIP will attach an Allow-Events SIP header to the initial INVITE and its responses 180 Ringing and 200 Ok (depending on incoming or outgoing call).
The Allow-Events header is only added in the initial request/response which is in accordance with RFC 3265 section 3.3.7.
If a NOTIFY request is received JsSIP will check if the client registered for events of the same type and if yes emit a 'newNotify' event and respond with 200 Ok.

I have tested this change on one of my PBXes by setting the appropriate events and verified that JsSIP correctly handles the corresponding NOTIFYs.

…s header.

This is in line with the industry standard for SIP talk & hold NOTIFY.
See RFC 3265 and SIPAccessSideExtensionsInterfaceSpec.
@wangduanduan
Copy link
Contributor

Waiting for the feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants