Skip to content

Commit

Permalink
Improve things and update deps
Browse files Browse the repository at this point in the history
  • Loading branch information
ibc committed Nov 6, 2022
1 parent 35e961b commit e63de93
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 12 deletions.
14 changes: 14 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,20 @@ Just valid if `source` is "device". Specifies the device options used by `ffmpeg
When sending, `dataChannel.send()` (and hence `dataProducer.send()`) allows passing a string, a `Buffer` instance or an `ArrayBuffer` instance.
## Development
In order to run `npm run lint` task, the following Python dependencies are required:
- `flake8` >= 5.0.4
- `mypy` >= 0.982
Install them with `pip` command:
```bash
$ pip3 install flake8==5.0.4 mypy==0.982
```
## Caveats
See the list of [open issues](https://github.com/versatica/mediasoup-client-aiortc/issues).
Expand Down
2 changes: 1 addition & 1 deletion npm-scripts.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ switch (task)

execute('MEDIASOUP_NODE_LANGUAGE=typescript eslint -c .eslintrc.js --ext=ts src/');
execute('MEDIASOUP_NODE_LANGUAGE=javascript eslint -c .eslintrc.js --ext=js --ignore-pattern \'!.eslintrc.js\' .eslintrc.js npm-scripts.js test/');
execute(`${PYTHON3} -m flake8 worker/`);
execute(`cd worker && ${PYTHON3} -m flake8 && cd ..`);
execute(`cd worker && ${PYTHON3} -m mypy . && cd ..`);

break;
Expand Down
20 changes: 10 additions & 10 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,23 +42,23 @@
"dependencies": {
"event-target-shim": "^6.0.2",
"fake-mediastreamtrack": "^1.1.6",
"mediasoup-client": "^3.6.56",
"mediasoup-client": "^3.6.58",
"netstring": "^0.3.0",
"sdp-transform": "^2.14.1",
"uuid": "^8.3.2"
"uuid": "^9.0.0"
},
"devDependencies": {
"@types/node": "^18.7.6",
"@types/node": "^18.11.9",
"@types/sdp-transform": "^2.4.5",
"@types/uuid": "^8.3.4",
"@typescript-eslint/eslint-plugin": "^5.33.1",
"@typescript-eslint/parser": "^5.33.1",
"eslint": "^8.22.0",
"eslint-plugin-jest": "^26.8.3",
"jest": "^28.1.3",
"@typescript-eslint/eslint-plugin": "^5.42.0",
"@typescript-eslint/parser": "^5.42.0",
"eslint": "^8.27.0",
"eslint-plugin-jest": "^27.1.4",
"jest": "^29.2.2",
"jest-tobetype": "^1.2.3",
"open-cli": "^7.0.1",
"open-cli": "^7.1.0",
"tsc-watch": "^5.0.3",
"typescript": "^4.7.4"
"typescript": "^4.8.4"
}
}
2 changes: 1 addition & 1 deletion worker/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
license="MIT",
packages=setuptools.find_packages(),
install_requires=[
"aiortc>=0.9.28",
"aiortc>=1.3.2",
"pynetstring"
],
)

0 comments on commit e63de93

Please sign in to comment.